Avoid leaking backtrace on connection lost in arcam #98277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elupus
commented
Aug 11, 2023
| try: | ||
| await self._state.update() | ||
| except ConnectionFailed as connection: | ||
| _LOGGER.debug("Connection lost during update: %s", connection) |
There was a problem hiding this comment.
Must swallow the exception here since we don't catch these cleanly without backtrace at the moment.
frenck
added
the
smash
bdraco
reviewed
Aug 14, 2023
| except (KeyError, ValueError): | ||
| _LOGGER.error("Unsupported sound_mode %s", sound_mode) | ||
| return | ||
| except (KeyError, ValueError) as exception: |
There was a problem hiding this comment.
Would be a bit nicer if the lib threw a named exception here
There was a problem hiding this comment.
Somewhat standard exceptions. But sure. Will look at it later.
bdraco
approved these changes
Aug 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Avoid leaking arcam connection lost exceptions with backtrace into logs. These are expected when a device is suddenly turned off from remote control.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: