Fix GoGoGate2 configuration URL when remote access is disabled

[oyvindwe]

Proposed change

Fix the configuration URL for a GoGoGate2/iSmartGate device when remote access is disabled. Use local IP in configuration URL if remote access is disabled.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue: Fixes the broken configration URL reported in Ismartgate doesn't communicate when internet is off-line #95587 (comment)
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @vangorra, mind taking a look at this pull request as it has been labeled with an integration (gogogate2) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of gogogate2 can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign gogogate2 Removes the current integration label and assignees on the pull request, add the integration domain after the command.

[joostlek]

I just checked the issue, and I don't think the whole issue will be solved with this change as this only changes the stored configuration URL in home assistant. It doesn't change the URL the library connects to.

[oyvindwe]

I just checked the issue, and I don't think the whole issue will be solved with this change as this only changes the stored configuration URL in home assistant. It doesn't change the URL the library connects to.

Correct, also I did not claim to fix the original problem in the reported issue, only the the related issue from the linked comment. It does not change any stored configuration though, it only generates a working link for devices without remote access (of course only reachable if you are on your local network).

[joostlek]

Ah right, I thought it was placed after Fixed in the description (so I thought it would autoclose that issue). 👍

[oyvindwe]

Ah right, I thought it was placed after Fixed in the description (so I thought it would autoclose that issue). 👍

I took care to place it after "related to issue". The original problem is not yet isolated. :/

Edit: added a missing not.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[MartinHjelmare]

Thanks!