Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create certain start.ca sensors for unlimited plans #98525

Merged
merged 1 commit into from Aug 16, 2023

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Aug 16, 2023

Breaking change

Start.ca limit, usage and used_remaining sensor will no longer be created when there's no bandwidth cap

Proposed change

Don't create limit, usage or used_remaining startca sensors when there's no bandwidth cap
These sensors were previously created but would set their state to inf which is no longer allowed for numerical sensors

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
@emontnemery Is there a doc's PR needed?

@emontnemery emontnemery changed the title Don't create certain startca sensors for unlimited setups Don't create certain start.ca sensors for unlimited setups Aug 16, 2023
@emontnemery emontnemery changed the title Don't create certain start.ca sensors for unlimited setups Don't create certain start.ca sensors for unlimited plans Aug 16, 2023
@emontnemery emontnemery merged commit 8ed7d2d into dev Aug 16, 2023
21 checks passed
@emontnemery emontnemery deleted the startca_tweak_unlimited_setups branch August 16, 2023 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants