Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reolink add pan position sensor #98592

Merged
merged 3 commits into from Aug 19, 2023

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Aug 17, 2023

Breaking change

Proposed change

Reolink add pan position sensor.
Unit is unknown, probably motor steps, in case of my E1 Zoom it is between 0 (left) and 7360 (right).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot marked this pull request as draft August 18, 2023 18:18
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@starkillerOG starkillerOG marked this pull request as ready for review August 19, 2023 10:15
@gjohansson-ST
Copy link
Member

Looks good 👍
You can't control the ptz from HA so this should actually be something else than just a sensor displaying the value?

@starkillerOG
Copy link
Contributor Author

starkillerOG commented Aug 19, 2023

You can't control the ptz from HA so this should actually be something else than just a sensor displaying the value?

Correct: there is no way (yet) in the API to set the absolute pan postion.
You can use the button entities to start a continues pan movement (left or right) and the PTZ stop button to stop after a while.
This sensor then provides the absolute position.

I did request the reolink firmware engineers to add the ability to set the absolute pan position (and get/set the tilt position), and they would look into it, but that will most likely be more than a year if it even gets implemented....

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @starkillerOG 👍

@gjohansson-ST gjohansson-ST merged commit 39fc4b3 into home-assistant:dev Aug 19, 2023
21 checks passed
@starkillerOG starkillerOG deleted the reolink_pan_position branch August 19, 2023 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants