New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pyspcwebgw to 0.7.0 #98593
Bump pyspcwebgw to 0.7.0 #98593
Conversation
@jschlyter Please could you add a link to a diff between the two library versions in the change description? Many thanks! |
Done. |
I didn't see a link...? Please could you add one in the form: https://github.com/xxxxx/xxxx/compare/vX.X.X...vX.X.Y We need this because we want to look at what has actually changed in the library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As already mentioned above by Dave; Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:
- A link to the release notes of this package version, and all versions in between.
- A link to the changelog of this package.
- A link to a Git(Hub) diff/compare view from the current version to the bumped version.
This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.
Thanks already! 👍
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jschlyter 👍
../Frenck
Proposed change
Upgrade
pyspcwebgw
dependency. Changes from 0.4.0:Full changelog from 0.4.0 to 0.7.0 available at pyspcwebgw/pyspcwebgw@0.4.0...v0.7.0 with releases published at https://github.com/pyspcwebgw/pyspcwebgw/releases.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: