Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyspcwebgw to 0.7.0 #98593

Merged
merged 3 commits into from Aug 21, 2023
Merged

Conversation

jschlyter
Copy link
Contributor

@jschlyter jschlyter commented Aug 17, 2023

Proposed change

Upgrade pyspcwebgw dependency. Changes from 0.4.0:

  • fix PART_SET last_change_by user
  • Expose ethernet information
  • Panel info like model, firmware version and serial number is now automatically fetched.
  • Implement PIR workarounds

Full changelog from 0.4.0 to 0.7.0 available at pyspcwebgw/pyspcwebgw@0.4.0...v0.7.0 with releases published at https://github.com/pyspcwebgw/pyspcwebgw/releases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@davet2001 davet2001 changed the title Upgrade pyspcwebgw dependency Bump pyspcwebgw to 0.7.0 Aug 18, 2023
@davet2001
Copy link
Contributor

@jschlyter Please could you add a link to a diff between the two library versions in the change description? Many thanks!

@jschlyter
Copy link
Contributor Author

@jschlyter Please could you add a link to a diff between the two library versions in the change description? Many thanks!

Done.

@davet2001
Copy link
Contributor

I didn't see a link...? Please could you add one in the form:

https://github.com/xxxxx/xxxx/compare/vX.X.X...vX.X.Y

We need this because we want to look at what has actually changed in the library.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As already mentioned above by Dave; Thanks for bumping the dependency! However, could you please update the PR description to contain at least one (or multiple) of the following:

  • A link to the release notes of this package version, and all versions in between.
  • A link to the changelog of this package.
  • A link to a Git(Hub) diff/compare view from the current version to the bumped version.

This allows us to review upstream changes, which is needed to decide this change is working as intended and/or if we can include it in, for example, a patch release of Home Assistant.

Thanks already! 👍

@home-assistant home-assistant bot marked this pull request as draft August 18, 2023 09:05
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jschlyter jschlyter marked this pull request as ready for review August 18, 2023 13:16
@home-assistant home-assistant bot requested a review from frenck August 18, 2023 13:16
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jschlyter 👍

../Frenck

@frenck frenck merged commit 180dd3d into home-assistant:dev Aug 21, 2023
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants