New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add indoor sensors to Honeywell integration #98609
Add indoor sensors to Honeywell integration #98609
Conversation
Hey there @rdfurman, @mkmer, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. All comments from previous PR are here :)
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@frenck @gjohansson-ST @mkmer Do I need to fix these CI issues? These are pre-existing issues not related to the code I added. |
Yes, you will need to fix this. The problem is related to the code you are working on. |
Still not sure how I broke it since I didn't touch the async_setup_entry method but I was able to fix it by adding an appropriate import. All should finally be good and ready to go! :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a tiny improvement to use constant als for translations keys ;)
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
BTW: If you haven't, run the tests locally - otherwise it will fail here and delay the merge. Hope a clean run will get us over the hill.
@edenhaus @gjohansson-ST Do you think you will have time to review and approve so we can get my PR in the September release? It would be much appreciated. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a PR for the docs and update the description to link it.
My apologies. I took care of it last week and checked the appropriate box in the checklist but neglected to add the link to the documentation PR. That has been fixed. |
@edenhaus Documentation has been updated and the PR has been linked to the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jakecolman 👍
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: