Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indoor sensors to Honeywell integration #98609

Merged
merged 12 commits into from Aug 28, 2023

Conversation

jakecolman
Copy link
Contributor

@jakecolman jakecolman commented Aug 18, 2023

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rdfurman, @mkmer, mind taking a look at this pull request as it has been labeled with an integration (honeywell) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of honeywell can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign honeywell Removes the current integration label and assignees on the pull request, add the integration domain after the command.

Copy link
Contributor

@mkmer mkmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All comments from previous PR are here :)

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jakecolman jakecolman marked this pull request as ready for review August 20, 2023 02:58
Copy link
Contributor

@mkmer mkmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 21, 2023
@jakecolman
Copy link
Contributor Author

@frenck @gjohansson-ST @mkmer Do I need to fix these CI issues? These are pre-existing issues not related to the code I added.

@mkmer
Copy link
Contributor

mkmer commented Aug 21, 2023

Yes, you will need to fix this. The problem is related to the code you are working on.

@jakecolman
Copy link
Contributor Author

Still not sure how I broke it since I didn't touch the async_setup_entry method but I was able to fix it by adding an appropriate import. All should finally be good and ready to go! :-)

@jakecolman jakecolman requested a review from mkmer August 21, 2023 22:41
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a tiny improvement to use constant als for translations keys ;)

homeassistant/components/honeywell/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/honeywell/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/honeywell/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/honeywell/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 22, 2023 15:53
@edenhaus edenhaus removed the smash Indicator this PR is close to finish for merging or closing label Aug 22, 2023
jakecolman and others added 4 commits August 22, 2023 13:36
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
Co-authored-by: Robert Resch <robert@resch.dev>
@jakecolman jakecolman marked this pull request as ready for review August 22, 2023 17:37
@home-assistant home-assistant bot requested a review from edenhaus August 22, 2023 17:38
homeassistant/components/honeywell/const.py Outdated Show resolved Hide resolved
homeassistant/components/honeywell/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/honeywell/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 22, 2023 18:08
jakecolman and others added 3 commits August 22, 2023 20:12
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
Co-authored-by: G Johansson <goran.johansson@shiftit.se>
@jakecolman jakecolman marked this pull request as ready for review August 24, 2023 00:59
Copy link
Contributor

@mkmer mkmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
BTW: If you haven't, run the tests locally - otherwise it will fail here and delay the merge. Hope a clean run will get us over the hill.

homeassistant/components/honeywell/const.py Show resolved Hide resolved
@jakecolman
Copy link
Contributor Author

@edenhaus @gjohansson-ST Do you think you will have time to review and approve so we can get my PR in the September release? It would be much appreciated. Thanks.

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a PR for the docs and update the description to link it.

@home-assistant home-assistant bot marked this pull request as draft August 28, 2023 08:42
@jakecolman
Copy link
Contributor Author

jakecolman commented Aug 28, 2023

Please create a PR for the docs and update the description to link it.

My apologies. I took care of it last week and checked the appropriate box in the checklist but neglected to add the link to the documentation PR. That has been fixed.

@jakecolman jakecolman marked this pull request as ready for review August 28, 2023 11:38
@home-assistant home-assistant bot requested a review from edenhaus August 28, 2023 11:38
@jakecolman
Copy link
Contributor Author

@edenhaus Documentation has been updated and the PR has been linked to the description.

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakecolman 👍

@edenhaus edenhaus merged commit f1378bb into home-assistant:dev Aug 28, 2023
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants