Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove operating binary_sensor from Enphase #98682

Merged
merged 1 commit into from Aug 19, 2023

Conversation

cgarwood
Copy link
Member

@cgarwood cgarwood commented Aug 19, 2023

Proposed change

Remove the operating binary_sensor from the Enphase Envoy component. In Envoy firmware v8 this data is no longer available through the API.

This binary sensor has only ever been in dev, so I don't believe it would classify as a breaking change.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bdraco, @dgomes, @joostlek, mind taking a look at this pull request as it has been labeled with an integration (enphase_envoy) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of enphase_envoy can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign enphase_envoy Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@cgarwood cgarwood marked this pull request as ready for review August 19, 2023 17:17
@joostlek
Copy link
Member

Can't we make this only available for <8?

@bdraco
Copy link
Member

bdraco commented Aug 19, 2023

Can't we make this only available for <8?

We don't know if it actually does anything for 7 so probably best to remove it so we don't have a breaking change later

@bdraco bdraco merged commit 91965a7 into home-assistant:dev Aug 19, 2023
21 checks passed
@cgarwood
Copy link
Member Author

Yeah, it seems like a pretty narrow window of systems it is actually available for (Firmware 7 with Enpower/IQ system controller and Encharge batteries) so figured best to just scrap it.

@cgarwood cgarwood changed the title Enphase remove operating Remove operating binary_sensor from Enphase Aug 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 20, 2023
@cgarwood cgarwood deleted the enphase_remove_operating branch November 2, 2023 12:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants