Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional sensors for Tuya DIN #98752

Merged
merged 3 commits into from Nov 25, 2023

Conversation

cronjefourie
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tuya can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tuya Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@cronjefourie
Copy link
Contributor Author

Trying to add the fix a 2nd time. The 1st time I mucked up with the re-base :D

@MartinHjelmare MartinHjelmare changed the title Added additional sensors for Tuya DIN Add additional sensors for Tuya DIN Aug 21, 2023
@cronjefourie
Copy link
Contributor Author

tried the "update branch" button

jbouwh
jbouwh previously requested changes Aug 29, 2023
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add tests as well

.gitignore Outdated Show resolved Hide resolved
homeassistant/components/tuya/sensor.py Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 29, 2023 11:19
@cronjefourie
Copy link
Contributor Author

cronjefourie commented Aug 29, 2023 via email

@frenck
Copy link
Member

frenck commented Nov 25, 2023

Removed a small unrelated change, rebased the whole PR onto the latest dev branch (which also cleaned up some commits because of that).

@frenck frenck marked this pull request as ready for review November 25, 2023 13:58
@home-assistant home-assistant bot requested a review from jbouwh November 25, 2023 13:58
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cronjefourie 👍

../Frenck

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 25, 2023
@frenck frenck dismissed jbouwh’s stale review November 25, 2023 13:58

Comments addressed

@frenck frenck merged commit 03caa21 into home-assistant:dev Nov 25, 2023
23 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed integration: tuya Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants