New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional sensors for Tuya DIN #98752
Add additional sensors for Tuya DIN #98752
Conversation
Hey there @tuya, @zlinoliver, @frenck, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Trying to add the fix a 2nd time. The 1st time I mucked up with the re-base :D |
tried the "update branch" button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests as well
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Oh yea I added that so that it ignores my VSCode workspace file
…On Tue, 29 Aug 2023 at 13:19, Jan Bouwhuis ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Can you add tests as well
------------------------------
In .gitignore
<#98752 (comment)>
:
> @@ -135,3 +135,4 @@ tmp_cache
# python-language-server / Rope
.ropeproject
+*.code-workspace
Seems this line is unrelated to the PR. Please remove it.
⬇️ Suggested change
-*.code-workspace
------------------------------
In homeassistant/components/tuya/sensor.py
<#98752 (comment)>
:
> @@ -818,6 +818,27 @@ class TuyaSensorEntityDescription(SensorEntityDescription):
native_unit_of_measurement=UnitOfElectricPotential.VOLT,
subkey="voltage",
),
+ TuyaSensorEntityDescription(
+ key=DPCode.CUR_CURRENT,
+ translation_key="current",
I do not see the strings file updated.
—
Reply to this email directly, view it on GitHub
<#98752 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADEWPUOJKLEGBDADUR4QXADXXXF4RANCNFSM6AAAAAA3YMPI3Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
fdad15b
to
2809f1b
Compare
Removed a small unrelated change, rebased the whole PR onto the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @cronjefourie 👍
../Frenck
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: