Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loop.time in DataUpdateCoordinator #98937

Merged
merged 9 commits into from Aug 28, 2023
Merged

Conversation

emontnemery
Copy link
Contributor

Proposed change

Use loop.time in DataUpdateCoordinator

Rationale: Calls to utcnow() are expensive on some platforms. The DataUpdateCoordinator does not need to sleep until a precise wall clock time, so we can use loop.time() instead

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner August 24, 2023 07:27
@emontnemery emontnemery marked this pull request as draft August 24, 2023 07:27
@MartinHjelmare
Copy link
Member

Looks promising. Are there other questions?

@bdraco
Copy link
Member

bdraco commented Aug 25, 2023

Looks like its close to passing. Happy to put this on all my production for live testing when its ready for final review

@bdraco
Copy link
Member

bdraco commented Aug 25, 2023

Pushing on to my houston production now.. Will report back in the morning

@bdraco
Copy link
Member

bdraco commented Aug 25, 2023

Profile looks good, manual testing looks good.

Will report back tomorrow

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested overnight. All good

Looks like this is good to go once tests are sorted

@emontnemery emontnemery reopened this Aug 28, 2023
@emontnemery emontnemery marked this pull request as ready for review August 28, 2023 14:14
@emontnemery
Copy link
Contributor Author

@bdraco tests pass now, do you think it's OK to merge it?

@bdraco
Copy link
Member

bdraco commented Aug 28, 2023

@bdraco tests pass now, do you think it's OK to merge it?

Yes. Been running on multiple production for a while now with no issues

@bdraco bdraco merged commit 9dac6a2 into dev Aug 28, 2023
59 of 61 checks passed
@bdraco bdraco deleted the update_coordinator_loop_time branch August 28, 2023 15:16
@bdraco
Copy link
Member

bdraco commented Aug 28, 2023

Thanks @emontnemery

@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2023
@elupus
Copy link
Contributor

elupus commented Sep 12, 2023

I'm pondering if this could be the background to: #100221

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants