Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always update unit of measurement of the utility_meter on state change #99102

Merged
merged 2 commits into from Sep 10, 2023

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Aug 26, 2023

Breaking change

Proposed change

When the utility_meter is initially added and the source for some reason does not have a unit_of_measurement, the utility_meter would never get a unit itself.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@dgomes dgomes requested a review from bdraco September 10, 2023 13:25
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a bit iffy to change the UOM at run time since I don't think we account for it everywhere. There may be side effects we didn't think about in downstream code. It looks like sensor at least tries to handle this though so let's do it and fix anything downstream if needed as I don't see another way with this type of integration / wrapper.

@bdraco bdraco merged commit 553cdfb into home-assistant:dev Sep 10, 2023
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
@dgomes dgomes added this to the 2023.9.3 milestone Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utility Meter (hourly reset) not showing unit_of_measurement
4 participants