Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiounifi to v58 #99103

Merged
merged 4 commits into from Aug 26, 2023
Merged

Bump aiounifi to v58 #99103

merged 4 commits into from Aug 26, 2023

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Aug 26, 2023

Breaking change

Proposed change

Kane610/aiounifi@v55...v58
57 should fix some packaging issues that include typing
58 should loosen restrictions on version requirements
This PR is primarily affected by Kane610/aiounifi#459 as it moves some functionality around.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@Kane610 Kane610 changed the title Bump aiounifi to v56 Bump aiounifi to v57 Aug 26, 2023
@Kane610
Copy link
Member Author

Kane610 commented Aug 26, 2023

Thanks @bdraco 🎉

@Kane610 Kane610 changed the title Bump aiounifi to v57 Bump aiounifi to v58 Aug 26, 2023
@bdraco bdraco merged commit 45efe29 into home-assistant:dev Aug 26, 2023
34 checks passed
@Kane610 Kane610 deleted the unifi-bump_to_56 branch August 27, 2023 05:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants