Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-bsblan to 0.5.16 #99238

Merged
merged 3 commits into from Aug 30, 2023
Merged

Conversation

liudger
Copy link
Contributor

@liudger liudger commented Aug 28, 2023

Proposed change

Bump python-bsblan to v0.5.16
Fix compatibility with ruff and pydantic and security updates.
Deps have been moved to dev.

liudger/python-bsblan@v0.5.11...v0.5.16

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Aug 29, 2023

Can ruff be made a dev dependency instead?

@liudger
Copy link
Contributor Author

liudger commented Aug 29, 2023

Can ruff be made a dev dependency instead?

I'll have a look.

@MartinHjelmare MartinHjelmare changed the title bump python-bsblan Bump python-bsblan to 0.5.15 Aug 29, 2023
homeassistant/components/bsblan/manifest.json Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 29, 2023 11:48
moved ruff and covdefault to dev dep
@bdraco bdraco changed the title Bump python-bsblan to 0.5.15 Bump python-bsblan to 0.5.16 Aug 29, 2023
@liudger liudger marked this pull request as ready for review August 29, 2023 17:58
@bdraco
Copy link
Member

bdraco commented Aug 29, 2023

Please adjust the opening text to reflect the new version and provide a link to the diff/changelog for the new version

@bdraco bdraco dismissed MartinHjelmare’s stale review August 29, 2023 18:09

deps have been moved to dev

@bdraco bdraco marked this pull request as draft August 29, 2023 18:10
@liudger
Copy link
Contributor Author

liudger commented Aug 29, 2023

Please adjust the opening text to reflect the new version and provide a link to the diff/changelog for the new version

Missed it. Text and link fixed

@liudger liudger marked this pull request as ready for review August 29, 2023 18:16
@liudger
Copy link
Contributor Author

liudger commented Aug 29, 2023

I see there is another error with a test.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liudger

@bdraco bdraco merged commit 1e37e1e into home-assistant:dev Aug 30, 2023
34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
@liudger liudger deleted the bump-python-bsblan branch August 31, 2023 14:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants