Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zwave_js controller status sensor #99252

Merged
merged 9 commits into from Aug 30, 2023

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Aug 29, 2023

Proposed change

Adds new controller status sensor. I chose the best status icons I could find but I don't love them, open to changes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@raman325 raman325 marked this pull request as draft August 29, 2023 06:20
@raman325 raman325 marked this pull request as ready for review August 29, 2023 06:46
@raman325
Copy link
Contributor Author

BTW, I just realized that if we have these status sensors, we may not need to show them in the device info card. They are collapsed by default anyway and the node status should be visible. Let me know what you think about that - we can remove some code if needed

homeassistant/components/zwave_js/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/zwave_js/sensor.py Outdated Show resolved Hide resolved
tests/components/zwave_js/test_sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 30, 2023 07:19
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

raman325 and others added 3 commits August 30, 2023 06:33
@raman325 raman325 marked this pull request as ready for review August 30, 2023 10:41
@raman325 raman325 merged commit 6e5f456 into home-assistant:dev Aug 30, 2023
21 checks passed
@raman325 raman325 deleted the controller_status branch August 30, 2023 10:50
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants