Add yolink siren battery entity #99310
Conversation
home-assistant
bot
added
cla-signed
integration: yolink
new-feature
small-pr
MartinHjelmare
changed the title
| and state.get("powerSupply") == "usb" | ||
| ): | ||
| # When the power supply mode is usb, the power information is wrong | ||
| state["battery"] = None |
There was a problem hiding this comment.
We shouldn't modify to correct the data coming from the api. If it needs adjustment it should be done in the device library.
Is this a device that can both be powered by USB and battery and power supply can change during the entity lifetime?
There was a problem hiding this comment.
Thanks, I will change on API library, When the device has a battery installed and is powered by USB, the battery power obtained is inaccurate.
There was a problem hiding this comment.
I think just remove message convert is fine, When a battery is installed in the device, if device changed to USB power supply, if device battery level displayed as unavailable, which is unreasonable.
There was a problem hiding this comment.
Is this the current behavior, that the sensor becomes unavailable if the power supply changes to USB? Where is the logic for this?
There was a problem hiding this comment.
At my first commit, I tried to change siren battery entity value to None (unavailable) when device power supply change to USB, I think that is incorrect, When a battery is installed in the device, should not change siren battery entity to None even if the battery information is not correct(circuit design leads to)，So I think just remove message convert is fine. No API library changes required.
There was a problem hiding this comment.
Setting the value None as the sensor native value will be translated to unknown state in the base entity class, not unavailable state.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Nevermind this comment. I misread the change. It is a new sensor. |
|
Please mark the PR as ready for review when it's ready to merge. |
Proposed change
Add Siren device battery entity.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: