Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly reduce overhead to filter event triggers #99376

Merged
merged 9 commits into from Aug 31, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 31, 2023

Proposed change

The large number of vol.Schema validate_mapping calls was contributing to sluggish performance and poor response times. In most cases we can avoid it and do a simple dict .items() compare. For complex nested cases, continue to fallback to the expensive vol.Schema validate_mapping path (these should be rare and there are much better ways to write the automations already available).

profile courtesy of @Madelena

filter_event
filter_event_cycle

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (homeassistant) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homeassistant can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign homeassistant Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco
Copy link
Member Author

bdraco commented Aug 31, 2023

This one is slow enough to impact the UI and be a major contributing factor to integrations triggering the slow update warning.

Will tag for beta and undraft after running it on production for a bit.

@bdraco bdraco added this to the 2023.9.0 milestone Aug 31, 2023
@bdraco bdraco marked this pull request as ready for review August 31, 2023 08:10
@bdraco bdraco requested a review from a team as a code owner August 31, 2023 08:10
@balloob balloob merged commit 0da94c2 into dev Aug 31, 2023
34 checks passed
@balloob balloob deleted the event_trigger_fast_compare branch August 31, 2023 17:47
bramkragten pushed a commit that referenced this pull request Sep 1, 2023
* fast

* cleanups

* cleanups

* cleanups

* comment

* comment

* add more cover

* comment

* pull more examples from forums to validate cover
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants