Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reolink onvif not supported fix #99714

Merged
merged 4 commits into from Sep 6, 2023
Merged

Reolink onvif not supported fix #99714

merged 4 commits into from Sep 6, 2023

Conversation

starkillerOG
Copy link
Contributor

Breaking change

Proposed change

Ensure the Reolink integration can also be used for (really old) cameras that do not support ONVIF:
For instance the RLC-423 Hardware-Version IPC_3816M which is a old hardware version of the already discontinued RLC-423 model.
In that case the integration will fall back on using fast polling

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG mentioned this pull request Sep 6, 2023
Closed
@starkillerOG starkillerOG added this to the 2023.9.0 milestone Sep 6, 2023
emontnemery
emontnemery approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @starkillerOG 👍

@emontnemery emontnemery merged commit 0037385 into home-assistant:dev Sep 6, 2023
21 checks passed
bramkragten pushed a commit that referenced this pull request Sep 6, 2023
@starkillerOG @bramkragten
Reolink onvif not supported fix (#99714)
107ca83 
* only subscibe to ONVIF if supported

* Catch NotSupportedError when ONVIF is not supported

* fix styling
@starkillerOG starkillerOG deleted the reolink_onvif_not_supported branch September 6, 2023 14:18
@starkillerOG
Copy link
Contributor Author

@emontnemery @bramkragten thanks for getting this in HA 2023.9.0 so fast!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emontnemery emontnemery emontnemery approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: reolink Quality Scale: No score
Projects
None yet
Milestone
2023.9.0
Development

Successfully merging this pull request may close these issues.

Reolink fails to start for RLC-423 because of the lack of ONVIF
3 participants
@starkillerOG @emontnemery @bramkragten