Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow changing device class in template binary sensor options #99720

Merged
merged 1 commit into from Sep 6, 2023

Conversation

emontnemery
Copy link
Contributor

Proposed change

Don't allow changing device class in template binary sensor options

Rationale:
The device class can be overridden from entity options, updating the device class option will then not do anything

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 6, 2023

Hey there @PhracturedBlue, @tetienne, @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (template) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of template can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign template Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@emontnemery emontnemery added this to the 2023.9.0 milestone Sep 6, 2023
@MartinHjelmare
Copy link
Member

Do we hook into the entity options directly in the config flow that creates the helper entity? Otherwise it seems like not the best UX to set the device class later after creating the entity.

@emontnemery
Copy link
Contributor Author

@MartinHjelmare No, but I don't think that matters? With this PR the initial device class can be set from the config flow and changed from device options

@emontnemery emontnemery merged commit c376447 into dev Sep 6, 2023
33 of 34 checks passed
@emontnemery emontnemery deleted the template_helper_drop_option_flow_device_class branch September 6, 2023 13:59
@MartinHjelmare
Copy link
Member

Ok, I thought it was completely removed from the config flow.

@emontnemery
Copy link
Contributor Author

emontnemery commented Sep 6, 2023

Ok, I thought it was completely removed from the config flow.

That's what #99718 did, but there was some discussion in the beta channel and the conclusion was to allow setting the device class in the config flow but only update it via entity settings.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants