New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dataclass to carry data in ping #99803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
testing on production now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All ping sensors are showing unavailable after this change
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I don't see any obvious errors or anything in the logs so I'm not sure where the problem is unfortunately. |
Might be a race as I restarted again and now they are |
I think we have an existing bug here, but I can't find it |
Still haven't found the bug. Seems to happen even without this PR so I don't think the problem is coming in here. |
I'll now run this on my production system as well, have only tested this on dev. Maybe I can find this. |
Interestingly, I cannot reproduce this on either Prod is |
I'll try to dig in some more today. I don't expect this PR is the cause. If I can't find the problem, I'll set up a clean system to test this so we can get it moving forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and tested with dev
and the problem has gone away. I wish I could explain it, but its clear its not caused by this PR
Thanks for testing this again @bdraco 👍 |
Thanks @jpbede Sorry I took so long to get back to this one. |
Proposed change
Use a
dataclass
to transfer theprivileged
state (and maybe others later) between platforms. Also add myself as a code owner.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: