Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugwise to v0.32.2 #99973

Merged
merged 5 commits into from Sep 9, 2023
Merged

Bump plugwise to v0.32.2 #99973

merged 5 commits into from Sep 9, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Sep 9, 2023

Proposed change

Update plugwise to v0.32.2: https://github.com/plugwise/python-plugwise/releases/tag/v0.32.2
Full changelog: plugwise/python-plugwise@v0.31.9...v0.32.2

Short summary of the changes in the backend:

  • Add support for changing the temperature-offset on a supported thermostat device (this feature will be added to Core Plugwise in a follow-up PR).
  • Major code clean-up: improve coding, improve typing, fix some small hidden errors. The code should now be ready to enable strict-typing.
  • This update solves an issue identified in Plugwise: KeyError: 'setpoint' #99372: when an entity disappears on the Plugwise device, it stays available in HA in a "frozen" state due to the way the backend updates its data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Sep 9, 2023

Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of plugwise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign plugwise Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bouwew bouwew marked this pull request as ready for review September 9, 2023 12:47
@bouwew bouwew requested a review from frenck as a code owner September 9, 2023 12:47
@joostlek joostlek added this to the 2023.9.2 milestone Sep 9, 2023
@joostlek joostlek changed the title Update plugwise to v0.32.2 Bump plugwise to v0.32.2 Sep 9, 2023
@joostlek joostlek merged commit 081d0bd into home-assistant:dev Sep 9, 2023
34 checks passed
@bouwew
Copy link
Contributor Author

bouwew commented Sep 10, 2023

Thanks for reviewing and merging!

I will create the follow-up PR that adds the temperature_offset number as a new feature soon.

@bouwew bouwew deleted the pw_0_32_2 branch September 10, 2023 08:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugwise: KeyError: 'setpoint'
4 participants