Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid probing ipp printers for unique_id when it is available via mdns #99982

Merged
merged 5 commits into from Sep 12, 2023
Merged

Avoid probing ipp printers for unique_id when it is available via mdns #99982

merged 5 commits into from Sep 12, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 9, 2023 •
edited

Proposed change

We would always probe the device in the ipp flow and than abort if it was already configured. We avoid the probe for most printers.

This can cause some printers to lock up when there are many HA instances on the network.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco
Avoid probing ipp printers for unique_id when it is available via mdns
ec4aea8 
We would always probe the device in the ipp flow and than
abort if it was already configured. We avoid the probe for
most printers.
@home-assistant
Copy link

home-assistant bot commented Sep 9, 2023

Hey there @ctalkington, mind taking a look at this pull request as it has been labeled with an integration (ipp) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ipp can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ipp Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco bdraco marked this pull request as ready for review September 9, 2023 14:06
@bdraco bdraco added this to the 2023.9.2 milestone Sep 9, 2023
@bdraco
Copy link
Member Author

bdraco commented Sep 9, 2023

I had some stability issues with my printer and tracked it down to this.

I also have 12 HA test installs on my network though

jbouwh
jbouwh approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @bdraco 👍

@bdraco
Copy link
Member Author

bdraco commented Sep 10, 2023

It looks like code-owner-approval is a hard merge block now so I can't merge this one

@ctalkington
Copy link
Contributor

thanks @bdraco sorry just saw this

@balloob balloob merged commit a20d1a3 into dev Sep 12, 2023
21 checks passed
@balloob balloob deleted the ipp_probes branch September 12, 2023 02:34
balloob pushed a commit that referenced this pull request Sep 12, 2023
@bdraco @balloob
Avoid probing ipp printers for unique_id when it is available via mdns (
3d09e85 
#99982)

* Avoid probing ipp printers for unique_id when it is available via mdns

We would always probe the device in the ipp flow and than
abort if it was already configured. We avoid the probe for
most printers.

* dry

* coverage

* fix test

* add test for updating host
@balloob balloob mentioned this pull request Sep 12, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ctalkington ctalkington ctalkington approved these changes

@balloob balloob balloob approved these changes

@jbouwh jbouwh jbouwh approved these changes

Assignees

@ctalkington ctalkington

Labels
cherry-picked cla-signed code-owner-approved code-quality integration: ipp Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.9.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bdraco @ctalkington @balloob @jbouwh