Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assist (external bus) payload missing details / using implied defaults #17322

Closed
3 tasks done
jpelgrom opened this issue Jul 16, 2023 · 1 comment · Fixed by #17329
Closed
3 tasks done

Assist (external bus) payload missing details / using implied defaults #17322

jpelgrom opened this issue Jul 16, 2023 · 1 comment · Fixed by #17329

Comments

@jpelgrom
Copy link
Member

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

The (external bus) payload that is used for the Assist button in the top app bar and the 'Assist' tap action on a card does not always contain enough details for the app to respond correctly and uses implied defaults which may not match with the app.

Specifically I'm seeing:

  • It is implied that if start_listening isn't set, Assist shouldn't start listening, while for the app experience it should.
    This also translates to the tap action, where if "start listening?" is off it isn't sent on the external bus. There is no way for the app to distinguish this from the Assist action in the top app bar.
  • If no specific pipeline_id is supplied, it is implied that the last used pipeline or the preferred pipeline is used, depending on where it is triggered - top app bar: last used, action: preferred.
    This also applies to the frontend, see Assist action with 'Preferred assistant' opens last used assistant instead #17301. The lack of details here means the frontend always uses the last used pipeline while in the app it always uses the preferred pipeline.

Describe the behavior you expected

More details, see above

Steps to reproduce the issue

n/a

What version of Home Assistant Core has the issue?

core-2023.7.1

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Google Chrome 114.0.5735.199 (Official Build) (64-bit)

Which operating system are you using to run this browser?

Windows 11, version 22H2

State of relevant entities

No response

Problem-relevant frontend configuration

Payload for top app bar and a button with Assist action as configured below is empty ({}), while they should produce different behavior between frontend/app and top app bar/button.

Button card configuration:
show_name: true
show_icon: true
type: button
tap_action:
  action: assist
name: Assist me

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

@balloob
Copy link
Member

balloob commented Jul 16, 2023

I think that we should make this explicit by making start_listening and pipeline_id mandatory and allowing for 2 new unique values for pipeline_id: last_used and preferred. In the frontend we will then make sure that we will always pass a value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants