Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_used option for pipeline and explicit default #17329

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

piitaya
Copy link
Member

@piitaya piitaya commented Jul 17, 2023

Breaking changes

Assist action will open last used pipeline by default instead of preferred to be consistent with toolbar assist.

Proposed change

Adds new last_used option to assist action.

CleanShot 2023-07-17 at 17 14 04

Trigger assist from the toolbar :
It will start listening on app but not on web because web users often have a keyboard on web and it will not work on insecure contexts.
It will use the last used pipeline.

Trigger assist from the assist action :
If the pipeline_id is not set, the assist action will use the last used pipeline.
If the start_listening option is not set, this assist action will not start listening on web and app.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Let's wait for @jpelgrom to sign off on these changes before merging.

@piitaya piitaya added this to the 2023.8 Beta milestone Jul 17, 2023
Copy link
Member

@jpelgrom jpelgrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants