Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make persons config page translatable #3846

Closed
bramkragten opened this issue Oct 1, 2019 · 0 comments · Fixed by #3871
Closed

Make persons config page translatable #3846

bramkragten opened this issue Oct 1, 2019 · 0 comments · Fixed by #3871
Labels
hacktoberfest localization Translations and Localization

Comments

@bramkragten
Copy link
Member

All text in the Home Assistant UI should be translated.

The Persons config panel is not translated yet.

  • Create new keys in src/translations/en.json with the text that is currently hard coded in the source.
    Try to follow the same logic that is present, and give every section in Home Assistant it's own object.
    If you would place the text in
  "ui": {
    "panel": {
      "example": {
        "text": "Here goes the text",
      },
    },
  },

your key would be: "ui.panel.example.text

Polymer Elements need a mixin: LocalizeMixin(PolymerElement), Lit Elements work without a mixin.

  • Replace the text in the code with:
    • Lit element: ${this.hass.localize("ui.panel.example.text")}
    • Polymer: [[localize('ui.panel.history.showing_entries')]]

(This is part of #3429)

@bramkragten bramkragten added hacktoberfest localization Translations and Localization labels Oct 1, 2019
@bramkragten bramkragten changed the title Translate persons config page Make persons config page translatable Oct 1, 2019
svendroid added a commit to svendroid/home-assistant-polymer that referenced this issue Oct 3, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest localization Translations and Localization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant