Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create automation with device dialog has illegible text on dark theme #4664

Closed
3 tasks
SeanPM5 opened this issue Jan 30, 2020 · 0 comments · Fixed by #4671
Closed
3 tasks

Create automation with device dialog has illegible text on dark theme #4664

SeanPM5 opened this issue Jan 30, 2020 · 0 comments · Fixed by #4671
Assignees
@bramkragten
Labels
Bug Current Bug in UI - Extra Attention

Comments

@SeanPM5
Copy link
Contributor

SeanPM5 commented Jan 30, 2020

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.

The problem

Some text in the "Create automation with device" dialog is illegible on dark themes, the following:

Do something when...

Only do something if...

When something is triggered...

image

Expected behavior

Use primary text color variable for legible text

Steps to reproduce

  1. Use a dark theme
  2. Go to Device info > Create automation with device
  3. Look at text

Environment

  • Home Assistant release with the issue: 0.105.0b
  • Last working Home Assistant release (if known): 0.104.3
  • UI Type (States or Lovelace): Lovelace
  • Browser and browser version: chrome
  • Operating system: macOS

Problem-relevant configuration



Javascript errors shown in your browser console/inspector





Additional information

      		
    

      
  





        

            

            

              
            

        

      


      
    








      

    



      

  
          

  

    
  

  


    

        @SeanPM5
SeanPM5




        added
  the 

  Bug

  Current Bug in UI - Extra Attention
 label


    Jan 30, 2020

  





  

  

    
  

  


    

        @bramkragten
bramkragten




            self-assigned this


    Jan 30, 2020

  





  


  
    
  
  

    
  bramkragten 

      added a commit
      that referenced
      this issue

    
      Jan 30, 2020
    
    

      


  

    

      


  

      
        @bramkragten
  





      

        
          Device info page fixes
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          593a2de
        
      

    

  

    

      
Fixes #4666
Fixes #4664
Fixes #4663
Fixes #4662

    




    

  




  

  

    
  


  

      

    @bramkragten
bramkragten



    mentioned this issue
    
      Jan 30, 2020
    





  


  

      
   Merged

  







  




  

  


  

  

    
  

  


    

        @github-actions
github-actions
bot



      locked and limited conversation to collaborators


    Jul 6, 2022

  














  
  

    

      

  





  




  
  

             

  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.


  


  






  
                  




    

  


      
  

    Assignees
  



        

      

        

  
    @bramkragten
  
    bramkragten
    

      








      


  


  

    Labels
  



    

      

    Bug

  Current Bug in UI - Extra Attention








      

  

    

        

    Projects
  


        




    None yet




  



      

  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  




            
Successfully merging a pull request may close this issue.





    


  
          
      Device info page fixes

    
      home-assistant/frontend
    





    
  




        
      

    

  
      

  

    

      2 participants
    

    

        
          @bramkragten 
        
          @SeanPM5