Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon usage for sensors of the "energy" class is confusing #550

Closed
echox opened this issue Nov 2, 2017 · 3 comments
Closed

Icon usage for sensors of the "energy" class is confusing #550

echox opened this issue Nov 2, 2017 · 3 comments

Comments

@echox
Copy link
Contributor

echox commented Nov 2, 2017

First of all: More of a minor minor issue, if theres another place for this, please point me to it :)

I'm using the binary_sensor with the custom device class "power": https://home-assistant.io/components/binary_sensor/

"Power off" uses a "everything ok" icon.
"Power On" uses a warning icon.
screen shot 2017-11-02 at 17 32 16

While I can understand the viewpoint for this ("Danger! Electricity is on!") most of my use cases are "device is powered, everything is fine!".

If the state of "on" is dangerous, I would expect people to use the "safety" device class?

Or did I not understand the correct use of the classes? :)
@andrey-git
Copy link
Contributor

The example the doc uses for power is over-current, so "on" is indeed danger.
You can propose a new category with a pair of on/off icons :)

echox added a commit to echox/home-assistant-polymer that referenced this issue Nov 4, 2017
@echox
Introduced a new device class "plug" for the binary sensor.
5889057 
See home-assistant#550
@echox echox mentioned this issue Nov 4, 2017
Merged
@echox
Copy link
Contributor Author

echox commented Nov 4, 2017

Thanks you!

Created a pull request for that.
If it gets accepted, I would add it also to the documentation of home-assistant.github.io via another pull-request.

Did I miss anything else? :)

echox added a commit to echox/home-assistant.github.io that referenced this issue Nov 4, 2017
@echox
Added documentation for new device class 'plug'
e83b5e9 
See home-assistant/frontend#550
This was referenced Nov 4, 2017
Merged
Merged
balloob pushed a commit that referenced this issue Nov 5, 2017
@echox @balloob
Introduced a new device class "plug" for the binary sensor. (#558)
ba5f401 
* Introduced a new device class "plug" for the binary sensor.

See #550

* removed plug as domain
andrey-git pushed a commit to home-assistant/home-assistant.io that referenced this issue Nov 5, 2017
@echox @andrey-git
Added documentation for new device class 'plug' (#3889)
f78c4f3 
* Added documentation for new device class 'plug'

See home-assistant/frontend#550

* use term "unplugged"

* add the entry to the right place
@echox
Copy link
Contributor Author

echox commented Nov 6, 2017

Thanks for your support during the whole pull-request/merge process 👍
Everything is merged and I'm looking forward to the next update, so I'm closing this :)

@echox echox closed this as completed Nov 6, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@echox @andrey-git