inconsistent dialog width #60

roidayan · 2016-05-16T16:34:10Z

Version
0.30.0-dev

this happens with any dialog. for example i chose humidity. opening and closing the dialog gives different width each time. to be more precise it can be one of 2, narrow or wider. so each time it's one of the two.

wider

narrow

balloob · 2016-05-16T17:05:15Z

It happens because the first time the history API is not loaded yet.

On Mon, May 16, 2016 at 9:34 AM, Roi Dayan notifications@github.com wrote:

this happens with any dialog. for example i chose humidity. opening and
closing the dialog gives different width each time. to be more precise it
can be one of 2, narrow or wider. so each time it's one of the two.

wider
[image: screenshot_4]
https://cloud.githubusercontent.com/assets/660126/15296176/c6b82822-1b9c-11e6-8b13-ffe42cd3d2ee.png

narrow
[image: screenshot_5]
https://cloud.githubusercontent.com/assets/660126/15296178/c8643cec-1b9c-11e6-955d-6d5b901a725f.png

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#60

PaulusSchoutsen.nl
It's nice to be important but it's more important to be nice.

roidayan · 2016-05-16T19:24:48Z

But it continue to happen again without refreshing the page. Just closing and reopening the dialog.
It only happens on desktop view btw.
On tablet view the dialog keeps the same size though the graph is narrow or wide inside.

michaelarnauts · 2016-07-12T13:41:57Z

I still see this in the latest code in dev. Opening and closing the same popup a few times in a row can give a different sized popup. I didn't resize or move my browser window.

justweb1 · 2016-10-02T23:06:42Z

@roidayan Are you still experiencing this issue?

michaelarnauts · 2016-10-03T06:15:06Z

This is still occurring on 0.29.5.

justweb1 · 2016-10-06T13:08:57Z

@roidayan @michaelarnauts I'm only seeing this issue in modals that have state-history-chart-line. Are you seeing it anywhere else?

roidayan · 2016-10-06T13:54:03Z

I currently have an issue that I see the loading circle all the time and get an error that the sqlite db is busy. so I can't see any state history for any sensor. I'll try to check why and see if I get it in other state history charts.

roidayan · 2016-10-06T17:16:25Z

I also notice this in state-history-chart-timeline

justweb1 · 2016-10-08T12:44:07Z

@roidayan @michaelarnauts Please help me test this because it is an intermittent issue.

justweb1 · 2016-10-09T13:21:05Z

What browsers are you experiencing this issue on?
Are you still experiencing it in 0.30.1?

michaelarnauts · 2016-10-09T14:10:13Z

I always use Chrome, and it also occurs on the mobile version (Android).
Last tested version is 0.29.5.

Op zo 9 okt. 2016 15:21 schreef Justin Weberg notifications@github.com:

What browsers are you experiencing this issue on?
Are you still experiencing it in 0.30.1?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABI3MxRYSs8CxBJ5cZRI7n8ytetgihb8ks5qyOpCgaJpZM4Ife1o
.

Michaël Arnauts

roidayan · 2016-10-09T14:15:08Z

I also use chrome. Tested desktop and mobile on Android. I run 0.29.7.
I haven't tested the suggested css fix yet nor 0.30.1.

On Sun, Oct 9, 2016, 17:10 Michaël Arnauts notifications@github.com wrote:

I always use Chrome, and it also occurs on the mobile version (Android).
Last tested version is 0.29.5.

Op zo 9 okt. 2016 15:21 schreef Justin Weberg notifications@github.com:

What browsers are you experiencing this issue on?
Are you still experiencing it in 0.30.1?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
#60 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABI3MxRYSs8CxBJ5cZRI7n8ytetgihb8ks5qyOpCgaJpZM4Ife1o

.

Michaël Arnauts

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoSnof4Gx-EHBjuVRJBKFP35dJSKjtcks5qyPXGgaJpZM4Ife1o
.

justweb1 · 2016-10-09T17:26:06Z

It is happening on mobile too?

roidayan · 2016-10-09T17:27:48Z

Yes

On Sun, Oct 9, 2016, 20:26 Justin Weberg notifications@github.com wrote:

It is happening on mobile too?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoSnvuCGZrBCdQVK78aN_UBQK8sUNTpks5qySOvgaJpZM4Ife1o
.

michaelarnauts · 2016-10-09T19:03:13Z

Indeed, but there, the effect is different. The dialog always opens full
width, but the contents is too wide sometimes.

Op zo 9 okt. 2016 19:27 schreef Roi Dayan notifications@github.com:

Yes

On Sun, Oct 9, 2016, 20:26 Justin Weberg notifications@github.com wrote:

It is happening on mobile too?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
#60 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAoSnvuCGZrBCdQVK78aN_UBQK8sUNTpks5qySOvgaJpZM4Ife1o

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABI3M8nJ6Hv5E371DiLw70y1ozt6hlmtks5qySQWgaJpZM4Ife1o
.

Michaël Arnauts

justweb1 · 2016-10-09T20:05:50Z

Check out the PR for a fix for the desktop. I'll have to look more into mobile.

roidayan · 2016-10-09T21:38:04Z

In mobile the dialog has css width 100% I think so it always fits the
screen and in desktop width is auto so it fits according to the chart width.
I'll be able to check also the pr tomorrow.

On Sun, Oct 9, 2016, 23:05 Justin Weberg notifications@github.com wrote:

Check out the PR for a fix for the desktop. I'll have to look more into
mobile.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoSnjRJyDjJjyr7GaIjDrTqDbrPsVQCks5qyUkfgaJpZM4Ife1o
.

justweb1 · 2016-10-09T21:56:24Z

I'm not worried about mobile just yet. I will fix it but first I want to make sure the desktop version is fixed before I move on. I am not having any issues with inconsistency.

justweb1 · 2016-10-09T22:10:57Z

Also set max-width on history-charts to fix mobile issue #120

michaelarnauts · 2016-10-10T12:26:11Z

Two screenshots on mobile. See the width of the timeline. Above is correct. The page seems to chose randomly between the two versions.

justweb1 · 2016-10-10T12:32:16Z

Are you able to test the PR? I believe both issues are now fixed.

On Mon, Oct 10, 2016, 7:26 AM Michaël Arnauts notifications@github.com
wrote:

[image: screenshot_20161010-142253]
https://cloud.githubusercontent.com/assets/1193779/19235982/2f578366-8ef5-11e6-838d-40327e6da1dd.png

[image: screenshot_20161010-142247]
https://cloud.githubusercontent.com/assets/1193779/19235988/373ad8d0-8ef5-11e6-9f91-c5950738717e.png

Two screenshots on mobile. See the width of the timeline. Above is
correct. The page seems to chose randomly between the two versions.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKvitYHVDELuzq7qCW8eWbo1Gn6wrO8_ks5qyi7kgaJpZM4Ife1o
.

justweb1 · 2016-10-14T12:19:46Z

Fixed #120

michaelarnauts · 2016-10-30T21:59:43Z

I'm afraid this isn't fixed. See attached screenshot of version 0.31.1. Switches randomly between this state, and the correct state.

Bad:

Good:

michaelarnauts · 2016-12-05T13:03:24Z

@justweb1 could you re-open this issue?

This still happens in release 0.34.2

justweb1 · 2016-12-05T13:13:02Z

@michaelarnauts what browsers do you see the issue in?

michaelarnauts · 2016-12-05T13:19:07Z

Chrome (54) and Firefox (50). The dialog width itself seems to be the same (365px), but the svg sometimes renders at 400px wide.

justweb1 · 2016-12-05T13:23:31Z

Part of the problem is that component uses external scripts and at some point should be rewritten completely using the available Web component.

add login error

justweb1 mentioned this issue Oct 8, 2016

Fix inconsistent dialog width #120

Merged

justweb1 added the bug label Oct 8, 2016

justweb1 closed this as completed Oct 14, 2016

justweb1 reopened this Dec 5, 2016

justweb1 added the On Hold label Dec 5, 2016

andrey-git mentioned this issue Feb 14, 2017

Support multi-day history charts #207

Merged

c727 closed this as completed Mar 9, 2018

tkdrob pushed a commit to tkdrob/frontend that referenced this issue Apr 20, 2021

add login error (home-assistant#60)

628f011

add login error

github-actions bot locked and limited conversation to collaborators Jul 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

inconsistent dialog width #60

inconsistent dialog width #60

roidayan commented May 16, 2016 •

edited by justweb1

balloob commented May 16, 2016

roidayan commented May 16, 2016

michaelarnauts commented Jul 12, 2016

justweb1 commented Oct 2, 2016 •

edited

michaelarnauts commented Oct 3, 2016

justweb1 commented Oct 6, 2016

roidayan commented Oct 6, 2016

roidayan commented Oct 6, 2016 •

edited

justweb1 commented Oct 8, 2016

justweb1 commented Oct 9, 2016

michaelarnauts commented Oct 9, 2016

roidayan commented Oct 9, 2016

justweb1 commented Oct 9, 2016

roidayan commented Oct 9, 2016

michaelarnauts commented Oct 9, 2016

justweb1 commented Oct 9, 2016

roidayan commented Oct 9, 2016

justweb1 commented Oct 9, 2016

justweb1 commented Oct 9, 2016

michaelarnauts commented Oct 10, 2016

justweb1 commented Oct 10, 2016

justweb1 commented Oct 14, 2016

michaelarnauts commented Oct 30, 2016

michaelarnauts commented Dec 5, 2016

justweb1 commented Dec 5, 2016

michaelarnauts commented Dec 5, 2016

justweb1 commented Dec 5, 2016

inconsistent dialog width #60

inconsistent dialog width #60

Comments

roidayan commented May 16, 2016 • edited by justweb1

balloob commented May 16, 2016

roidayan commented May 16, 2016

michaelarnauts commented Jul 12, 2016

justweb1 commented Oct 2, 2016 • edited

michaelarnauts commented Oct 3, 2016

justweb1 commented Oct 6, 2016

roidayan commented Oct 6, 2016

roidayan commented Oct 6, 2016 • edited

justweb1 commented Oct 8, 2016

justweb1 commented Oct 9, 2016

michaelarnauts commented Oct 9, 2016

roidayan commented Oct 9, 2016

justweb1 commented Oct 9, 2016

roidayan commented Oct 9, 2016

michaelarnauts commented Oct 9, 2016

justweb1 commented Oct 9, 2016

roidayan commented Oct 9, 2016

justweb1 commented Oct 9, 2016

justweb1 commented Oct 9, 2016

michaelarnauts commented Oct 10, 2016

justweb1 commented Oct 10, 2016

justweb1 commented Oct 14, 2016

michaelarnauts commented Oct 30, 2016

michaelarnauts commented Dec 5, 2016

justweb1 commented Dec 5, 2016

michaelarnauts commented Dec 5, 2016

justweb1 commented Dec 5, 2016

roidayan commented May 16, 2016 •

edited by justweb1

justweb1 commented Oct 2, 2016 •

edited

roidayan commented Oct 6, 2016 •

edited