Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace no longer set google-green/google-red #6254

Closed
3 tasks
balloob opened this issue Jun 26, 2020 · 3 comments
Closed
3 tasks

Replace no longer set google-green/google-red #6254

balloob opened this issue Jun 26, 2020 · 3 comments
Labels
Bug Current Bug in UI - Extra Attention
Milestone

Comments

@balloob
Copy link
Member

balloob commented Jun 26, 2020

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.

The problem

When we swapped out paper-spinner for mwc in #6205, we also dropped setting four style variables that we kept around to style the spinner:

--google-red-500: #db4437;
--google-blue-500: #4285f4;
--google-green-500: #0f9d58;
--google-yellow-500: #f4b400;

The green and the red ones were actually quite widely used. We should introduce our own variables and find/replace the old references. And we should make sure the new variables will use google-red / google-green if they are defined first, to make it backwards compatible with existing themes.

Update: We actually already have error-color. We should use that one everywhere instead of google-red.

Expected behavior

Steps to reproduce

Environment

  • Home Assistant release with the issue:
  • Last working Home Assistant release (if known):
  • Browser and browser version:
  • Operating system:

State of relevant entities

Problem-relevant configuration

Javascript errors shown in your browser console/inspector

Additional information

@balloob balloob added the Bug Current Bug in UI - Extra Attention label Jun 26, 2020
@balloob balloob added this to the 0.112.0 milestone Jun 26, 2020
@balloob
Copy link
Member Author

balloob commented Jun 27, 2020

Idea from @thomasloven:

We should probably have like ok-color, warning-color and info-color too.

@balloob
Copy link
Member Author

balloob commented Jun 27, 2020

Note, bootstrap uses success-color instead of ok-color, which I like more

@thomasloven
Copy link
Contributor

I was thinking of bootstrap when I suggested it, but was too lazy to look up the names...

thomasloven added a commit that referenced this issue Jun 27, 2020
@balloob balloob mentioned this issue Jun 29, 2020
yosilevy pushed a commit to yosilevy/home-assistant-polymer that referenced this issue Jul 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Current Bug in UI - Extra Attention
Projects
None yet
Development

No branches or pull requests

2 participants