Add views dropdown and footer actions to the "move to view" dialog

[ghost]

Breaking change

Proposed change

Before:

After:

Closes #10083

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes Dialog to move a card to another Lovelace dashboard has an inconstant button #10083
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[homeassistant]

Hi @MartinTuroci,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[homeassistant]

Hi @MartinTuroci,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[bramkragten]

I'm not a big fan of this UX personally, the old UI could definitely use some clarification, but I feel like having to open another dropdown doesn't really help...

I think the buttons are a good idea, but lets keep a list, and add a selection indicator.

Let's wait for the verdict of @matthiasdebaat on this :-)

[matthiasdebaat]

Good that you mentioned how it looks like when there are more views.

This is how it looks right now.

My proposal is to use radiobuttons.

[ghost]

Will do @matthiasdebaat

[bramkragten]

Let's only do that if there is more than 1 view btw :-)

[ghost]

Let's only do that if there is more than 1 view btw :-)

@bramkragten What should be the fallback for a single view then? Non-clickable non-radio list item?

[ghost]

All review comments addressed, current state:

Waiting for clearance about single view edge case.

[bramkragten]

Let's only do that if there is more than 1 view btw :-)

@bramkragten What should be the fallback for a single view then? Non-clickable non-radio list item?

Or just don't render the view list at all? If there is 1 view you basically just move it to that dashboard? @matthiasdebaat ?

[matthiasdebaat]

Or just don't render the view list at all? If there is 1 view you basically just move it to that dashboard? @matthiasdebaat ?

Yeah, I agree

[ghost]

@matthiasdebaat so if there is only 1 view I should display a dialog with dashboard dropdown only?

[zsarnett]

I think we should keep the UI consistent even if there is only one...

Just make it checked. Not really a need to code around this case

[ghost]

I agree with @zsarnett. Having implicit option checked is probably better so that user knows what's going on.

[matthiasdebaat]

I think we should keep the UI consistent even if there is only one...

Just make it checked. Not really a need to code around this case

When there's only one view, there aren't tabs on the lovelace dashboard am I right? In that case it would be easier and more coherent to display a dialog with only a dashboard dropdown. When a users select a dashboard with multiple views it shows the different views.

[zsarnett]

There still is a view. It's just hidden from the header when there is only one.

[bramkragten]

There still is a view. It's just hidden from the header when there is only one.

Yes, but I don't see value in showing that to the user? Just like we dont show to the tabs when there is just 1 view?

[ghost]

Changed to show views only for > 1.

[bramkragten]

Looks good! 1 small remark