Add auto slider/box mode to number entity #10272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
|
Tested with home-assistant/core#56862 (in auto mode, w/o the core changes) - is it expected that the slider is only used in the state card?
|
|
It needs the core changes from home-assistant/core#57737 |
|
Yes, I just realized that, I suppose I just wanted to ask if there should be a fallback to the default (auto) as I'm not familiar with TS practices. I just rebased that WLED PR on top of 57737 for testing, and it's works great! :-)
|
balloob
reviewed
Oct 15, 2021
balloob
previously approved these changes
Oct 15, 2021
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
frenck
added
the
Breaking Change
balloob
approved these changes
Oct 18, 2021
balloob
reviewed
Oct 18, 2021
Comment on lines
+85
to
+88
| (stateObj.attributes.mode === "auto" && | ||
| (Number(stateObj.attributes.max) - Number(stateObj.attributes.min)) / | ||
| Number(stateObj.attributes.step) <= | ||
| 256) |
There was a problem hiding this comment.
Maybe idea to break this out in a helper function to reuse with state card.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
This extends the
numberentity with an optional mode, it provides a hint to the UI on how to represent this number entity in either a slider or box, similar to how we do it withinput_number.The difference is the
automode, which is the default. This should cover almost all cases out there and will be instantly applied to all existingnumberentities.When in
automode: If the range of possible positions on thenumberis 256 positions or smaller, it will become aslider, else aboxis automatically picked.The demo platform has been extended, the 2 existing entities (volume, PWM) have a fixed mode, while the large and small range entities have the default
automode.Backend PR: home-assistant/core#57737
Related to: home-assistant/core#56862
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: