Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix energy onboarding add_solar_production button (#10275) #10286

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Fix energy onboarding add_solar_production button (#10275) #10286

merged 1 commit into from
Oct 16, 2021

Conversation

aav7fl
Copy link
Contributor

@aav7fl aav7fl commented Oct 15, 2021

Proposed change

Fixes energy onboarding by adding the add solar production button back into the wizard process.

Every other single step in the energy wizard has a button to add consumption/return/storage. So I'm not sure why this was originally excluded.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

The real issue, and proper fix, is that we are not passing info to ha-energy-solar-settings like we do in the energy config page:

https://github.com/home-assistant/frontend/blob/dev/src/panels/config/energy/ha-config-energy.ts#L94

@aav7fl
Copy link
Contributor Author

aav7fl commented Oct 16, 2021

The real issue, and proper fix, is that we are not passing info to ha-energy-solar-settings like we do in the energy config page:

https://github.com/home-assistant/frontend/blob/dev/src/panels/config/energy/ha-config-energy.ts#L94

Thanks! That makes more sense now what the info was being used for now.

I've updated my PR by adding in the EnergyInfo just like the ha-energy-solar-settings. I added a similar _fetchconfig method where I set the value before the page loads. Hopefully that looks ok.

image

@bramkragten bramkragten merged commit 816d5ee into home-assistant:dev Oct 16, 2021
@aav7fl aav7fl deleted the fix-solar-add-button branch October 16, 2021 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Add solar" production button missing from Energy dashboard setup wizard
3 participants