Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABC automation types + use MWC #10287

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 15, 2021

Breaking change

Proposed change

Use MWC-SELECT for trigger, condition and action type pickers. These are considerd the "header" of the card and so them looking different is ok. Also sorts options by alphabet after translation.

image

image

image

Sorting example:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit a690a1d into dev Oct 16, 2021
@bramkragten bramkragten deleted the automation-editor-type-pickers-mwc branch October 16, 2021 12:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants