Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename stream_type to frontend_stream_type #10298

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Oct 16, 2021

Breaking change

Proposed change

Rename the stream_type variable to frontend_stream_type make it more clear this type controls frontend behavior only, since cameras can support multiple stream types in core. @frenck suggested this after we talked through an example where Tuya cameras may support both types of streams, and it makes sense to specify more clearly what the stream type controls. Original discussion for stream_type was in home-assistant/architecture#640

Core has been updated to set both frontend_stream_type and stream_type in home-assistant/core#57923

Planned cleanup steps are:

  • Rename stream_type to stream_frontend_type core
  • Rename this variable here
  • Release core nightly
  • Update frontend referenced in core nightly
  • Remove `stream_type in core

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@allenporter
Copy link
Contributor Author

Converting to draft since i changed the rollout plan, and will likely merge home-assistant/core#57923 first

@allenporter allenporter changed the title Rename stream_type to frontend_stream_type - part 1 Rename stream_type to frontend_stream_type Oct 18, 2021
Rename the stream_type variable to make it more clear this controls frontend
behavior only, since cameras can support multiple stream types in core, even
if only one type is used for frontend streams.

A followup PR will remove the original variable in core
@allenporter allenporter marked this pull request as ready for review October 18, 2021 03:27
@bramkragten bramkragten merged commit 84533b8 into home-assistant:dev Oct 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants