Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WebRTC stream error handling and cleanup #10302

Merged
merged 3 commits into from
Oct 18, 2021

Conversation

allenporter
Copy link
Contributor

Breaking change

Proposed change

Add error handler for setRemoteDescription, and keep track of peer connection and remote stream and run cleanup when closing the stream dialog.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Add error handler for setRemoteDescription, and keep track of peer connection
and remote stream and run cleanup when closing the stream dialog.
@bramkragten bramkragten merged commit a8486ed into home-assistant:dev Oct 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
@allenporter allenporter deleted the webrtc-close branch July 9, 2022 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants