Ensure current active dark modes gets used for manually set themes #10307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
If you manually set a theme for a single Lovelace component/card or view, the active dark mode had no effect, since the function
applyThemesOnElement
did not automatically consider the active mode.With this PR we now pull that in always from
hass.themes
if no input was provided explicitly by the caller. As a result I removed two code snippets from the hassio files, that did the same already explicitly.Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: