Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure current active dark modes gets used for manually set themes #10307

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

If you manually set a theme for a single Lovelace component/card or view, the active dark mode had no effect, since the function applyThemesOnElement did not automatically consider the active mode.

With this PR we now pull that in always from hass.themes if no input was provided explicitly by the caller. As a result I removed two code snippets from the hassio files, that did the same already explicitly.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit bdb3c04 into home-assistant:dev Oct 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light/Dark/Auto modes not applied to themes setup in lovelace views
3 participants