Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct grid neutrality card tooltip, make consistent with new colors #10326

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Correct grid neutrality card tooltip, make consistent with new colors #10326

merged 2 commits into from
Oct 19, 2021

Conversation

wtadler
Copy link
Contributor

@wtadler wtadler commented Oct 19, 2021

Proposed change

Before

This card represents your energy dependency.

If it's green, it means you produced more energy than that you
consumed from the grid. If it's in the red, it means that you
relied on the grid for part of your home's energy consumption.

After

This card indicates your net energy usage.

If the needle is in the purple, you returned more energy to the
grid than you consumed from it. If it's in the blue, you consumed
more energy from the grid than you returned. 

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@@ -103,11 +103,11 @@ class HuiEnergyGridGaugeCard
<paper-tooltip animation-delay="0" for="info" position="left">
<span>
${this.hass.localize(
"ui.panel.lovelace.cards.energy.grid_neutrality_gauge.energy_dependency"
"ui.panel.lovelace.cards.energy.grid_neutrality_gauge.net_energy_usage"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change translations keys if it isn't strictly needed, it causes all current translations to be lost.

@bramkragten bramkragten merged commit df53364 into home-assistant:dev Oct 19, 2021
@wtadler wtadler deleted the grid-neutrality-tooltip branch October 19, 2021 21:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants