Convert cloud account config to Lit #10350
Merged
+1,063
−966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
changed the title
balloob
reviewed
Oct 20, 2021
src/components/ha-alert.ts
Outdated
| @@ -41,8 +43,12 @@ class HaAlert extends LitElement { | |||
|
|
|||
| @property({ type: Boolean }) public dismissable = false; | |||
|
|
|||
| @property({ type: Boolean }) public ripple = false; | |||
There was a problem hiding this comment.
Why do we need this one? Can't we imply this if it's dismissable or has an action-text ?
There was a problem hiding this comment.
Don't forget to also add it to the gallery if we're sticking with a new attr.
There was a problem hiding this comment.
You had a ripple effect on the notification in the cloud login, just copied that logic. It has nothing to do with dismissable, it will just show a ripple effect for a second when shown 🤷♂️
There was a problem hiding this comment.
I'm totally fine with removing that ripple effect btw :-)
There was a problem hiding this comment.
Ah this is a ripple on open. Yeah let's remove it because we have a background color to draw attention.
bramkragten
force-pushed
the
account-convert-lit
branch
from
58bea33
to
ddd89fa
Compare
balloob
approved these changes
Oct 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: