Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure explicit false values from customize form get stored #10381

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

false values for explicitly added customize attributes should be stored, but currently the !value checks filters them out. Now we only rule them out if they are null or undefined.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

I don't see logic for undefined like in your description?

@spacegaier
Copy link
Member Author

I don't see logic for undefined like in your description?

To my understanding x == null (note the only two not three =) is equal to x === null || x === undefined.

@bramkragten
Copy link
Member

That's why we only use === ;-) Could you please adjust :-)

@spacegaier spacegaier merged commit b9bde19 into home-assistant:dev Oct 25, 2021
@spacegaier spacegaier deleted the issue-10377 branch October 25, 2021 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot customize programmatically set attribute to false
3 participants