Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various slugify() issues + add tests #10383

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

spacegaier
Copy link
Member

Breaking change

Proposed change

Existing logic had various issues:

  1. Only the first - was getting replaced => global flag added
  2. The existing logic to prevent duplicate delimiters in the output was hard-coded to two consecutive instances => now replaced by a generic solution
  3. The logic to trim any delimiter from the start of end was invalid and had no effect => fixed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 0c03839 into home-assistant:dev Oct 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device entity ID renaming fails when old device name has at least two hyphens
3 participants