Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation editor to gallery #10392

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Add automation editor to gallery #10392

merged 3 commits into from
Oct 25, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 25, 2021

Breaking change

Proposed change

Add automation trigger/condition/action to the gallery. Only added foundation with the default config for each type.

Looks better with #10265 because it breaks out the cards from the black/white row. But not required.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Oct 25, 2021
Comment on lines 22 to 23
device_id: string;
domain: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is part of DeviceAutomation which is extended.

@bramkragten bramkragten enabled auto-merge (squash) October 25, 2021 15:44
@bramkragten bramkragten merged commit dd11fb1 into dev Oct 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the automation-gallery branch October 25, 2021 15:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed hacktoberfest needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants