Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ha-form-integer to only show slider if < 256 steps #10430

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Oct 28, 2021

Breaking change

Proposed change

ha-form-integer now only show the slider if there are a max of 255 steps possible, otherwise show an input box.

Latest demo on https://617a2a06a3038f00076ef5dd--home-assistant-gallery.netlify.app/#demo-ha-form

Before:

image

After:

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob added this to the 2021.11.0 milestone Oct 28, 2021
@balloob balloob added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Oct 28, 2021
@bramkragten bramkragten merged commit 4b44e19 into dev Oct 28, 2021
@bramkragten bramkragten deleted the ha-form-integer-slider-constraints branch October 28, 2021 11:44
@bramkragten bramkragten mentioned this pull request Oct 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed hacktoberfest needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants