Make ha-chip-set slot-able #10647
Merged
Make ha-chip-set slot-able #10647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludeeus
added
the
needs design preview
balloob
changed the title
balloob
reviewed
Nov 19, 2021
balloob
reviewed
Nov 19, 2021
ludeeus
changed the title
balloob
reviewed
Nov 19, 2021
balloob
reviewed
Nov 19, 2021
| static get styles(): CSSResultGroup { | ||
| return css` | ||
| ${unsafeCSS(chipStyles)} | ||
|
|
||
| ha-chip { | ||
| slot::slotted(ha-chip) { | ||
| margin: 4px; |
There was a problem hiding this comment.
We now have on the left 8px (4px padding, 4px margin)
Docs show no margin on the left. Maybe we should do a margin-left: -4px on :host for chip-set?
https://m3.material.io/components/chips/overview
balloob
approved these changes
Nov 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: