New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iconColor to ha-config-navigation entries #10658
Conversation
I think we need to make those icon colors themeable, because the dark blue and dark green ones (basically the first 10 on the config page from the screenshot), will be trouble in the dark theme mode I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Ok to merge when dark mode colors added.
@matthiasdebaat can you provide some color codes for dark mode to use?
Ah yes, that looks indeed fine. SHIP IT. We can tweak it later. |
Will create a better color pallet, including dark mode colors. I picked the current ones just randomly with a color picker. |
Breaking change
Proposed change
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: