Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iconColor to ha-config-navigation entries #10658

Merged
merged 3 commits into from Nov 21, 2021

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 19, 2021

Breaking change

Proposed change

Screenshot from 2021-11-19 11-18-23

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus ludeeus added the needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview label Nov 19, 2021
@spacegaier
Copy link
Member

I think we need to make those icon colors themeable, because the dark blue and dark green ones (basically the first 10 on the config page from the screenshot), will be trouble in the dark theme mode I think.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Ok to merge when dark mode colors added.

@matthiasdebaat can you provide some color codes for dark mode to use?

@ludeeus
Copy link
Member Author

ludeeus commented Nov 21, 2021

I don't think the BG colors will have an issue.
But the icon inside should be white(-ish) color (at least by default) for both light and dark
image

@balloob
Copy link
Member

balloob commented Nov 21, 2021

Ah yes, that looks indeed fine. SHIP IT. We can tweak it later.

@balloob balloob merged commit a430142 into dev Nov 21, 2021
@balloob balloob deleted the Add-iconColor-to-ha-config-navigation-entries branch November 21, 2021 17:52
@matthiasdebaat
Copy link
Collaborator

Will create a better color pallet, including dark mode colors. I picked the current ones just randomly with a color picker.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed needs design preview PRs with this label will trigger a GitHub action to generate a gallery preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants