Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure required translations are loaded in safe-mode #10709

Merged
merged 1 commit into from Nov 29, 2021

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented Nov 26, 2021

Breaking change

Proposed change

It looks like the translations are not available in safe-mode. This PR SHOULD fix it, I am however not able to actually verify it, because no matter what I try the local frontend coding changes are not reflected at runtime. Is the safe-mode cached somehow differently or is it just that my purpose-fully invalid configuration.yaml prevents the startup from detecting my development_repo parameter馃槙?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten merged commit 9361e4c into home-assistant:dev Nov 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safe mode displays unlabeled button
3 participants