Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak how scenes behave in generated lovelace #10730

Merged
merged 1 commit into from Nov 30, 2021
Merged

Tweak how scenes behave in generated lovelace #10730

merged 1 commit into from Nov 30, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Nov 30, 2021

Breaking change

Proposed change

Fixes:

  • If a card only has footer entities, show the entities as normal entities

image

  • Cut off area name from the scene name
  • Wrap the buttons if it doesn't fit on 1 line
  • Pressing the scene will now activate it instead of toggling
  • Add 8px padding left/right to avoid the buttons hugging the card

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 49e3964 into dev Nov 30, 2021
@balloob balloob deleted the scene-updates branch November 30, 2021 00:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants