Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zwave_js config param should only be a toggle if there are 2 states #10812

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Dec 6, 2021

Proposed change

Right now we show a toggle to the user if enabled/enable and disabled/disable are in the available options for the config parameter, even if there are more than two options available. We should not do that and should instead use a dropdown to show the additional states when there are more than two options available.

I was not able to test this as I don't have a device that meets this criteria, but this should fix zwave-js/node-zwave-js#3836

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@raman325 raman325 added this to the 2021.12.0 milestone Dec 6, 2021
bramkragten
bramkragten previously approved these changes Dec 6, 2021
@balloob balloob merged commit a065740 into home-assistant:dev Dec 6, 2021
@raman325 raman325 deleted the config_states branch December 6, 2021 18:50
@balloob balloob mentioned this pull request Dec 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zooz Zen76 configuration not correct
4 participants