Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera stream rendering in area card without picture #10815

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented Dec 6, 2021

Breaking change

Proposed change

Fix for #10810.

If no area picture was set, the card behaved incorrectly when the new camera streaming was active.

Before:

image

After:
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@@ -3256,7 +3256,7 @@
"area": {
"name": "Area",
"description": "The Area card automatically displays entities of a specific area.",
"show_camera": "Show camera feed instead of area image"
"show_camera": "Show camera feed instead of area picture"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the wording we use also in the area and person config

@balloob balloob merged commit e8b9766 into home-assistant:dev Dec 6, 2021
@balloob balloob mentioned this pull request Dec 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants