Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clearing of picture (e.g. area and person config) #10816

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

spacegaier
Copy link
Member

@spacegaier spacegaier commented Dec 6, 2021

Breaking change

Proposed change

The change event of ha-file-upload was not reacted to in the ha-picture-upload so clearing was not possible.

Since this release brings the new area card with the picture being shown, I think this should go into the 2021.12 release still.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@spacegaier spacegaier added this to the 2021.12.0 milestone Dec 6, 2021
@balloob balloob merged commit 1916c17 into home-assistant:dev Dec 6, 2021
@spacegaier spacegaier deleted the issue-10751 branch December 6, 2021 22:18
@balloob balloob mentioned this pull request Dec 6, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close button in ha-picture-upload in dialog-person-details does not work
3 participants