Reorder configuration #10817
Merged
Reorder configuration #10817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What needs to be done for this still? Should we wait on it for a release or not? |
bramkragten
reviewed
Dec 6, 2021
| protected render(): TemplateResult { | ||
| return html` | ||
| ${this.pages.map((page) => | ||
| canShowPage(this.hass, page) | ||
| ( | ||
| page.path === "#external-app-configuration" |
There was a problem hiding this comment.
?
Suggested change
| page.path === "#external-app-configuration" | |
| page.component === "mobile_app" |
There was a problem hiding this comment.
No, your instance have the integration loaded, but this should only show if you are visiting from a app
bramkragten
reviewed
Dec 6, 2021
Comment on lines
+88
to
+90
| ev.currentTarget.parentElement.href.endsWith( | ||
| "#external-app-configuration" | ||
| ) |
There was a problem hiding this comment.
Not sure I like this, the url will stay changed, and it adds a entry to the history...
There was a problem hiding this comment.
This is how it used to be, but in ha-sidebar
bramkragten
reviewed
Dec 6, 2021
| @@ -77,6 +84,16 @@ class HaConfigNavigation extends LitElement { | |||
|
|
|||
| private _entryClicked(ev) { | |||
| ev.currentTarget.blur(); | |||
| if ( | |||
| ev.currentTarget.parentElement.href.endsWith( | |||
There was a problem hiding this comment.
Suggested change
| ev.currentTarget.parentElement.href.endsWith( | |
| ev.currentTarget.component === "mobile_app" |
balloob
approved these changes
Dec 6, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.figma.com/file/RSUZAyEXLdvmPWhonsI2xM/Menu?node-id=176%3A20671