Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WORKSPACE_DIRECTORY environment variable to devcontainer and script.core #11477

Merged
merged 3 commits into from Feb 12, 2022

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jan 28, 2022

Proposed change

use PWD env variable instead of static /workspaces/frontend which fails, when the repo is checked out into another folder (eg. /workspaces/homeassistant-frontend)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob
Copy link
Member

balloob commented Jan 28, 2022

This is a script used in our devcontainer. Joakim wrote it so let him review. I'm fine with making it more generic as long as the devcontainer continues to work 👍

@balloob balloob removed their request for review January 28, 2022 21:41
@mib1185
Copy link
Contributor Author

mib1185 commented Jan 28, 2022

I'm using the dev-container, but i did not clone the repo into frontend, but homeassistant-frontend so workspace folder is not /workspaces/frontend but /workspaces/homeassistant-frontend

script/core Outdated Show resolved Hide resolved
@mib1185 mib1185 requested a review from ludeeus February 12, 2022 00:21
script/core Outdated Show resolved Hide resolved
Copy link
Member

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ludeeus ludeeus changed the title Use PWD environment variable in script.core Add WORKSPACE_DIRECTORY environment variable to devcontainer and script.core Feb 12, 2022
@ludeeus ludeeus merged commit bef6591 into home-assistant:dev Feb 12, 2022
@mib1185 mib1185 deleted the script.core/use-PWD-env-variable branch February 12, 2022 11:21
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants