Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert selectors to MWC #11543

Merged
merged 3 commits into from Feb 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions gallery/src/pages/components/ha-selector.ts
Expand Up @@ -48,10 +48,15 @@ const SCHEMAS: {
boolean: { name: "Boolean", selector: { boolean: {} } },
time: { name: "Time", selector: { time: {} } },
action: { name: "Action", selector: { action: {} } },
text: { name: "Text", selector: { text: { multiline: false } } },
text: {
name: "Text",
selector: { text: { multiline: false } },
},
text_multiline: {
name: "Text multiline",
selector: { text: { multiline: true } },
selector: {
text: { multiline: true },
},
},
object: { name: "Object", selector: { object: {} } },
select: {
Expand Down
1 change: 1 addition & 0 deletions package.json
Expand Up @@ -67,6 +67,7 @@
"@material/mwc-switch": "0.25.3",
"@material/mwc-tab": "0.25.3",
"@material/mwc-tab-bar": "0.25.3",
"@material/mwc-textarea": "^0.25.3",
"@material/mwc-textfield": "0.25.3",
"@material/mwc-top-app-bar-fixed": "^0.25.3",
"@material/top-app-bar": "14.0.0-canary.261f2db59.0",
Expand Down
2 changes: 1 addition & 1 deletion src/components/ha-form/ha-form-integer.ts
Expand Up @@ -25,7 +25,7 @@ export class HaFormInteger extends LitElement implements HaFormElement {

@property({ type: Boolean }) public disabled = false;

@query("paper-input ha-slider") private _input?: HTMLElement;
@query("mwc-textfield ha-slider") private _input?: HTMLElement;

private _lastValue?: HaFormIntegerData;

Expand Down
21 changes: 10 additions & 11 deletions src/components/ha-selector/ha-selector-number.ts
@@ -1,11 +1,11 @@
import "@polymer/paper-input/paper-input";
import { css, CSSResultGroup, html, LitElement } from "lit";
import { customElement, property } from "lit/decorators";
import { classMap } from "lit/directives/class-map";
import { fireEvent } from "../../common/dom/fire_event";
import { NumberSelector } from "../../data/selector";
import { HomeAssistant } from "../../types";
import "../ha-slider";
import "@material/mwc-textfield/mwc-textfield";

@customElement("ha-selector-number")
export class HaNumberSelector extends LitElement {
Expand Down Expand Up @@ -36,27 +36,23 @@ export class HaNumberSelector extends LitElement {
>
</ha-slider>`
: ""}
<paper-input
<mwc-textfield
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not new in this PR, but can we do something about the width of slider vs input?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing that?
image

Firefox only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes... Firefox only

inputMode="numeric"
pattern="[0-9]+([\\.][0-9]+)?"
.label=${this.selector.number.mode !== "box" ? undefined : this.label}
.placeholder=${this.placeholder}
.noLabelFloat=${this.selector.number.mode !== "box"}
class=${classMap({ single: this.selector.number.mode === "box" })}
.min=${this.selector.number.min}
.max=${this.selector.number.max}
.value=${this.value}
.step=${this.selector.number.step ?? 1}
.disabled=${this.disabled}
.suffix=${this.selector.number.unit_of_measurement}
type="number"
auto-validate
@value-changed=${this._handleInputChange}
autoValidate
@input=${this._handleInputChange}
>
${this.selector.number.unit_of_measurement
? html`<div slot="suffix">
${this.selector.number.unit_of_measurement}
</div>`
: ""}
</paper-input>`;
</mwc-textfield>`;
}

private get _value() {
Expand Down Expand Up @@ -94,6 +90,9 @@ export class HaNumberSelector extends LitElement {
ha-slider {
flex: 1;
}
mwc-textfield {
width: 70px;
}
.single {
flex: 1;
}
Expand Down
47 changes: 20 additions & 27 deletions src/components/ha-selector/ha-selector-select.ts
@@ -1,9 +1,11 @@
import { css, CSSResultGroup, html, LitElement } from "lit";
import { customElement, property } from "lit/decorators";
import { fireEvent } from "../../common/dom/fire_event";
import { stopPropagation } from "../../common/dom/stop_propagation";
import { SelectSelector } from "../../data/selector";
import { HomeAssistant } from "../../types";
import "../ha-paper-dropdown-menu";
import "@material/mwc-select/mwc-select";
import "@material/mwc-list/mwc-list-item";

@customElement("ha-selector-select")
export class HaSelectSelector extends LitElement {
Expand All @@ -18,46 +20,37 @@ export class HaSelectSelector extends LitElement {
@property({ type: Boolean }) public disabled = false;

protected render() {
return html`<ha-paper-dropdown-menu
.disabled=${this.disabled}
return html`<mwc-select
fixedMenuPosition
naturalMenuWidth
.label=${this.label}
.value=${this.value}
.disabled=${this.disabled}
@closed=${stopPropagation}
@selected=${this._valueChanged}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>
<paper-listbox
slot="dropdown-content"
attr-for-selected="item-value"
.selected=${this.value}
@selected-item-changed=${this._valueChanged}
>
${this.selector.select.options.map(
(item: string) => html`
<paper-item .itemValue=${item}> ${item} </paper-item>
`
)}
</paper-listbox>
</ha-paper-dropdown-menu>`;
${this.selector.select.options.map(
(item: string) => html`
<mwc-list-item .value=${item}>${item}</mwc-list-item>
`
)}
</mwc-select>`;
}

private _valueChanged(ev) {
if (this.disabled || !ev.detail.value) {
ev.stopPropagation();
if (this.disabled || !ev.target.value) {
return;
}
fireEvent(this, "value-changed", {
value: ev.detail.value.itemValue,
value: ev.target.value,
});
}

static get styles(): CSSResultGroup {
return css`
ha-paper-dropdown-menu {
mwc-select {
width: 100%;
min-width: 200px;
display: block;
}
paper-listbox {
min-width: 200px;
}
paper-item {
cursor: pointer;
}
`;
}
Expand Down
5 changes: 0 additions & 5 deletions src/components/ha-selector/ha-selector-target.ts
@@ -1,8 +1,3 @@
import "@material/mwc-list/mwc-list";
import "@material/mwc-list/mwc-list-item";
import "@material/mwc-tab-bar/mwc-tab-bar";
import "@material/mwc-tab/mwc-tab";
import "@polymer/paper-input/paper-input";
import {
HassEntity,
HassServiceTarget,
Expand Down
38 changes: 24 additions & 14 deletions src/components/ha-selector/ha-selector-text.ts
@@ -1,10 +1,10 @@
import "@polymer/paper-input/paper-input";
import "@polymer/paper-input/paper-textarea";
import { html, LitElement } from "lit";
import { css, CSSResultGroup, html, LitElement } from "lit";
import { customElement, property } from "lit/decorators";
import { fireEvent } from "../../common/dom/fire_event";
import { StringSelector } from "../../data/selector";
import { HomeAssistant } from "../../types";
import "@material/mwc-textfield/mwc-textfield";
import "@material/mwc-textarea/mwc-textarea";

@customElement("ha-selector-text")
export class HaTextSelector extends LitElement {
Expand All @@ -22,25 +22,26 @@ export class HaTextSelector extends LitElement {

protected render() {
if (this.selector.text?.multiline) {
return html`<paper-textarea
return html`<mwc-textarea
.label=${this.label}
.placeholder=${this.placeholder}
.value=${this.value}
.value=${this.value || ""}
.disabled=${this.disabled}
@value-changed=${this._handleChange}
@input=${this._handleChange}
autocapitalize="none"
autocomplete="off"
spellcheck="false"
></paper-textarea>`;
required
></mwc-textarea>`;
}
return html`<paper-input
required
.value=${this.value}
.placeholder=${this.placeholder}
return html`<mwc-textfield
.value=${this.value || ""}
.placeholder=${this.placeholder || ""}
.disabled=${this.disabled}
@value-changed=${this._handleChange}
.label=${this.label}
></paper-input>`;
@input=${this._handleChange}
.label=${this.label || ""}
required
></mwc-textfield>`;
}

private _handleChange(ev) {
Expand All @@ -50,6 +51,15 @@ export class HaTextSelector extends LitElement {
}
fireEvent(this, "value-changed", { value });
}

static get styles(): CSSResultGroup {
return css`
mwc-textfield,
mwc-textarea {
width: 100%;
}
`;
}
}

declare global {
Expand Down
15 changes: 14 additions & 1 deletion yarn.lock
Expand Up @@ -2665,7 +2665,19 @@ __metadata:
languageName: node
linkType: hard

"@material/mwc-textfield@npm:0.25.3":
"@material/mwc-textarea@npm:^0.25.3":
version: 0.25.3
resolution: "@material/mwc-textarea@npm:0.25.3"
dependencies:
"@material/mwc-base": ^0.25.3
"@material/mwc-textfield": ^0.25.3
lit: ^2.0.0
tslib: ^2.0.1
checksum: 918e28b72f7c687c481cd9ee00f652cd6c212d37cd281197cb02c87f04153792c5a60a86276e82f44684e7c7b4947e0e2e5fceaa08fc075a030ea769c1501d8e
languageName: node
linkType: hard

"@material/mwc-textfield@npm:0.25.3, @material/mwc-textfield@npm:^0.25.3":
version: 0.25.3
resolution: "@material/mwc-textfield@npm:0.25.3"
dependencies:
Expand Down Expand Up @@ -9120,6 +9132,7 @@ fsevents@^1.2.7:
"@material/mwc-switch": 0.25.3
"@material/mwc-tab": 0.25.3
"@material/mwc-tab-bar": 0.25.3
"@material/mwc-textarea": ^0.25.3
"@material/mwc-textfield": 0.25.3
"@material/mwc-top-app-bar-fixed": ^0.25.3
"@material/top-app-bar": 14.0.0-canary.261f2db59.0
Expand Down